5 Pull Requests Review Guide

It "Should generate a UUID v7" {
    $guid = New-Guid
    $guid.ToString()[14] | Should -BeExactly '7'
}

UUID format: xxxxxxxx-xxxx-Vxxx-xxxx-xxxxxxxxxxxx

The V at 0-indexed position 14 is the version nibble. For v7, it's 7.

• #26140 — New-Guid (-Empty:$false)
• #26141 — Get-Uptime (-Since:$false)
• #26457 — Get-Random (-Shuffle:$false)
• #26460 — Get-SecureRandom (-Shuffle:$false)
• #26463 — Get-TimeZone (-ListAvailable:$false)
• #26469 — New-PSSession (-UseWindowsPowerShell:$false)
• #26474 — Split-Path (-Qualifier/-NoQualifier/-Leaf/-IsAbsolute:$false)
• #26479 — Test-Connection (-Repeat/-MtuSize/-Traceroute:$false)
• #26485 — Where-Object (-[Operator]:$false)

// Before (line 246) — ?? has lower priority than +
int capacity = length + prependStr?.Length ?? 0 + appendStr?.Length ?? 0;

// After — explicit grouping
int capacity = length + (prependStr?.Length ?? 0) + (appendStr?.Length ?? 0);

// Before
private static bool logInitialized = false;

// After
private static volatile bool logInitialized = false;

// Before — RunspaceRef used before null check
if (_isRunspacePushed)
    return RunspaceRef.OldRunspace as LocalRunspace;
if (RunspaceRef == null) return null;

// After — null check first
if (RunspaceRef == null) return null;
if (_isRunspacePushed)
    return RunspaceRef.OldRunspace as LocalRunspace;

// Before — instance used without null check
CimInstance instance = GetCimInstanceParameter(cmdlet);
nameSpace = instance.CimSystemProperties.Namespace;

// After — null guard added
CimInstance instance = GetCimInstanceParameter(cmdlet);
if (instance != null)
{
    nameSpace = instance.CimSystemProperties.Namespace;
    ...
}

// Before
this.Module = other.Members["Module"].Value as ShowCommandModuleInfo;

// After
this.Module = other.Members["Module"]?.Value as ShowCommandModuleInfo;

// Before — vd.mainControl accessed in both branches
if (vd == null || mainControlType != vd.mainControl.GetType())
{
    ActiveTracer.WriteLine("NOT MATCH ...",
        ControlBase.GetControlShapeName(vd.mainControl), ...);
}

// After — separate checks
if (vd == null)
{
    ActiveTracer.WriteLine("NOT MATCH null view definition");
    continue;
}
if (mainControlType != vd.mainControl.GetType())
{
    ActiveTracer.WriteLine("NOT MATCH ...", ...);
    continue;
}